Fix non-nullable columns in MySQL migration for Spring Batch 4.3 #4145
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmbenhassine
added
pr-for: bug
in: core
for: backport-to-4.3.x
fmbenhassine
pushed a commit
that referenced
this pull request
Aug 24, 2022
|
LGTM. Rebased and merged as 6bbd9d8. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database migration for MySQL to Spring Batch 4.3 currently misses
NOT NULLconstraints fromBATCH_JOB_EXECUTION.CREATE_TIMEandBATCH_STEP_EXECUTION.START_TIME.If the current migration is applied to a Spring Batch database < 4.3, it effectively removes the existing
NOT NULLconstraints although they are still contained inschema-mysql.sql.