Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect deprecation of ItemStreamSupport #4238

Closed
hpoettker opened this issue Nov 18, 2022 · 1 comment
Closed

Incorrect deprecation of ItemStreamSupport #4238

hpoettker opened this issue Nov 18, 2022 · 1 comment

Comments

@hpoettker
Copy link
Contributor

Starting with Spring Batch 5, the whole abstract class ItemStreamSupport is deprecated and marked for removal.

For the methods close, open, and update, the default implementations of ItemStream yield a one-to-one replacement, respectively. ItemStreamSupport also has the methods setName, setExecutionContextName, and getExecutionContextKey, for which no replacements exist as far as I can tell.

Is there a replacement available for the latter methods? Or are only the methods that are inherited from ItemStream planned to be removed? If so, why not remove them without deprecation?

@hpoettker hpoettker added the status: waiting-for-triage Issues that we did not analyse yet label Nov 18, 2022
@fmbenhassine fmbenhassine added this to the 5.0.0 milestone Nov 22, 2022
@fmbenhassine fmbenhassine added type: bug in: core and removed status: waiting-for-triage Issues that we did not analyse yet labels Nov 22, 2022
@fmbenhassine
Copy link
Contributor

Thank you for pointing this. That's correct, only the methods open, close and update should deprecated, not the entire class. This will be fixed for 5.0 GA.

@fmbenhassine fmbenhassine changed the title Clarify deprecation of ItemStreamSupport Incorrect deprecation of ItemStreamSupport Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants