Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now throttlerLimit() is deprecated everywhere, providing a ThrottlerRepeatOperations could be convenient #4531

Open
nightswimmings opened this issue Jan 8, 2024 · 1 comment
Labels
status: waiting-for-triage Issues that we did not analyse yet type: feature

Comments

@nightswimmings
Copy link

nightswimmings commented Jan 8, 2024

As per the note "@deprecated with no replacement since 5.0, scheduled for removal in 6.0. Use a custom {@link RepeatOperations} implementation (based on a {@link TaskExecutor} with a bounded task queue) and set it on the step with {@link #stepOperations(RepeatOperations)}.", I think it would be convenient to have some built-in replacement.

IMO this is pertinent because:

  • It saves a significant effort to anyone that wants to upgrade
  • I believe it is really something quite intrinsical to an expected Batch API
  • It implies one of the most sensible ways of dealing with low-level stuff, concurrency and synchronization, and you all are much more aware of how things work in behind

My 2 cents, but thanks either way!

@nightswimmings nightswimmings added status: waiting-for-triage Issues that we did not analyse yet type: feature labels Jan 8, 2024
@Mom0aut
Copy link

Mom0aut commented Apr 15, 2024

Could someone provide an real example of how i can set the "old" throttleLimit with the "new" RepeatOperations.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage Issues that we did not analyse yet type: feature
Projects
None yet
Development

No branches or pull requests

2 participants