Constructors with var args/Lists #686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think is a good enhancement mostly when creating jobs with java configuration it can reduce code lines but we must generalize it for all items |
|
@hbourada any particular classes you have in mind? I was keeping this PR's scope low with targeting core and support classes especially for, like you said, usefulness with java config. |
drumonii
force-pushed
the
add-constructors-to-take-list-and-var-args
branch
from
b55494a
to
3948b4b
Compare
For classes that have a setter for a List<T> field, create Constructors that take List<T> and var args of T.
drumonii
force-pushed
the
add-constructors-to-take-list-and-var-args
branch
from
3948b4b
to
55f7992
Compare
fmbenhassine
added
in: infrastructure
status: waiting-for-triage
fmbenhassine
removed
the
status: waiting-for-triage
fmbenhassine
pushed a commit
that referenced
this pull request
Mar 21, 2022
For classes that have a setter for a List<T> field, create Constructors that take List<T> and var args of T. Issue #686
|
LGTM. Rebased and merged as 15e18e5. Thank you for your contribution! |
lcmarvin
pushed a commit
to lcmarvin/spring-batch
that referenced
this pull request
Apr 16, 2022
For classes that have a setter for a List<T> field, create Constructors that take List<T> and var args of T. Issue spring-projects#686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds constructors that take a
Listor var args to classes that set aListfield.I did a rudimentary search through the code to find
List<. So if I'm missing a class, I can easily add the appropriate constructors.I can create an issue for this if needed. I found it to be fairly trivial since it's only constructor updates. Hence, I didn't update the
@author. I did update the copyright year.