diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java index e3f227af7705..b1e6969ee763 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java @@ -17,8 +17,6 @@ package org.springframework.boot.autoconfigure.web.reactive; import java.time.Duration; -import java.util.ArrayList; -import java.util.List; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -52,7 +50,6 @@ import org.springframework.context.annotation.Import; import org.springframework.core.Ordered; import org.springframework.core.annotation.Order; -import org.springframework.core.io.ResourceLoader; import org.springframework.format.FormatterRegistry; import org.springframework.format.support.FormattingConversionService; import org.springframework.http.codec.ServerCodecConfigurer; @@ -159,14 +156,12 @@ public static class WebFluxConfig implements WebFluxConfigurer { private final ObjectProvider viewResolvers; - private final ResourceLoader resourceLoader; - public WebFluxConfig(org.springframework.boot.autoconfigure.web.ResourceProperties resourceProperties, WebProperties webProperties, WebFluxProperties webFluxProperties, ListableBeanFactory beanFactory, ObjectProvider resolvers, ObjectProvider codecCustomizers, ObjectProvider resourceHandlerRegistrationCustomizer, - ObjectProvider viewResolvers, ResourceLoader resourceLoader) { + ObjectProvider viewResolvers) { this.resourceProperties = resourceProperties.hasBeenCustomized() ? resourceProperties : webProperties.getResources(); this.webFluxProperties = webFluxProperties; @@ -175,7 +170,6 @@ public WebFluxConfig(org.springframework.boot.autoconfigure.web.ResourceProperti this.codecCustomizers = codecCustomizers; this.resourceHandlerRegistrationCustomizer = resourceHandlerRegistrationCustomizer.getIfAvailable(); this.viewResolvers = viewResolvers; - this.resourceLoader = resourceLoader; } @Override @@ -195,28 +189,17 @@ public void addResourceHandlers(ResourceHandlerRegistry registry) { return; } if (!registry.hasMappingForPattern("/webjars/**")) { - String webjarsLocation = "classpath:/META-INF/resources/webjars/"; - if (this.resourceLoader.getResource(webjarsLocation).exists()) { - ResourceHandlerRegistration registration = registry.addResourceHandler("/webjars/**") - .addResourceLocations(webjarsLocation); - configureResourceCaching(registration); - customizeResourceHandlerRegistration(registration); - } + ResourceHandlerRegistration registration = registry.addResourceHandler("/webjars/**") + .addResourceLocations("classpath:/META-INF/resources/webjars/"); + configureResourceCaching(registration); + customizeResourceHandlerRegistration(registration); } String staticPathPattern = this.webFluxProperties.getStaticPathPattern(); if (!registry.hasMappingForPattern(staticPathPattern)) { - List foundLocations = new ArrayList<>(); - for (String staticLocation : this.resourceProperties.getStaticLocations()) { - if (this.resourceLoader.getResource(staticLocation).exists()) { - foundLocations.add(staticLocation); - } - } - if (!foundLocations.isEmpty()) { - ResourceHandlerRegistration registration = registry.addResourceHandler(staticPathPattern) - .addResourceLocations(foundLocations.toArray(new String[0])); - configureResourceCaching(registration); - customizeResourceHandlerRegistration(registration); - } + ResourceHandlerRegistration registration = registry.addResourceHandler(staticPathPattern) + .addResourceLocations(this.resourceProperties.getStaticLocations()); + configureResourceCaching(registration); + customizeResourceHandlerRegistration(registration); } } diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.java index b6e8cd1b69a2..a919f42862d8 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/WebMvcAutoConfiguration.java @@ -201,8 +201,6 @@ public static class WebMvcAutoConfigurationAdapter implements WebMvcConfigurer, private final ResourceHandlerRegistrationCustomizer resourceHandlerRegistrationCustomizer; - private final ResourceLoader resourceLoader; - private ServletContext servletContext; public WebMvcAutoConfigurationAdapter( @@ -211,7 +209,7 @@ public WebMvcAutoConfigurationAdapter( ObjectProvider messageConvertersProvider, ObjectProvider resourceHandlerRegistrationCustomizerProvider, ObjectProvider dispatcherServletPath, - ObjectProvider> servletRegistrations, ResourceLoader resourceLoader) { + ObjectProvider> servletRegistrations) { this.resourceProperties = resourceProperties.hasBeenCustomized() ? resourceProperties : webProperties.getResources(); this.mvcProperties = mvcProperties; @@ -220,7 +218,6 @@ public WebMvcAutoConfigurationAdapter( this.resourceHandlerRegistrationCustomizer = resourceHandlerRegistrationCustomizerProvider.getIfAvailable(); this.dispatcherServletPath = dispatcherServletPath; this.servletRegistrations = servletRegistrations; - this.resourceLoader = resourceLoader; this.mvcProperties.checkConfiguration(); } @@ -337,11 +334,7 @@ public void addResourceHandlers(ResourceHandlerRegistry registry) { logger.debug("Default resource handling disabled"); return; } - Resource webjarsLocationResource = this.resourceLoader - .getResource("classpath:/META-INF/resources/webjars/"); - if (webjarsLocationResource.exists()) { - addResourceHandler(registry, "/webjars/**", webjarsLocationResource); - } + addResourceHandler(registry, "/webjars/**", "classpath:/META-INF/resources/webjars/"); addResourceHandler(registry, this.mvcProperties.getStaticPathPattern(), (registration) -> { registration.addResourceLocations(this.resourceProperties.getStaticLocations()); if (this.servletContext != null) { @@ -351,7 +344,7 @@ public void addResourceHandlers(ResourceHandlerRegistry registry) { }); } - private void addResourceHandler(ResourceHandlerRegistry registry, String pattern, Resource... locations) { + private void addResourceHandler(ResourceHandlerRegistry registry, String pattern, String... locations) { addResourceHandler(registry, pattern, (registration) -> registration.addResourceLocations(locations)); } diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfigurationTests.java b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfigurationTests.java index 636844b2b40c..18eacf173338 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfigurationTests.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfigurationTests.java @@ -157,10 +157,9 @@ void shouldRegisterResourceHandlerMapping() { SimpleUrlHandlerMapping hm = context.getBean("resourceHandlerMapping", SimpleUrlHandlerMapping.class); assertThat(hm.getUrlMap().get("/**")).isInstanceOf(ResourceWebHandler.class); ResourceWebHandler staticHandler = (ResourceWebHandler) hm.getUrlMap().get("/**"); - assertThat(staticHandler).extracting("locationValues").asList().hasSize(2); - assertThat(staticHandler.getLocations()).hasSize(2); - assertThat(staticHandler.getLocations().get(0)).hasToString("class path resource [META-INF/resources/]"); - assertThat(staticHandler.getLocations().get(1)).hasToString("class path resource [public/]"); + assertThat(staticHandler).extracting("locationValues").asList().hasSize(4); + assertThat(staticHandler.getLocations()).hasSize(1); + assertThat(staticHandler.getLocations().get(0)).hasToString("class path resource [public/]"); assertThat(hm.getUrlMap().get("/webjars/**")).isInstanceOf(ResourceWebHandler.class); ResourceWebHandler webjarsHandler = (ResourceWebHandler) hm.getUrlMap().get("/webjars/**"); assertThat(webjarsHandler).extracting("locationValues").asList() @@ -174,7 +173,7 @@ void shouldMapResourcesToCustomPath() { SimpleUrlHandlerMapping hm = context.getBean("resourceHandlerMapping", SimpleUrlHandlerMapping.class); assertThat(hm.getUrlMap().get("/static/**")).isInstanceOf(ResourceWebHandler.class); ResourceWebHandler staticHandler = (ResourceWebHandler) hm.getUrlMap().get("/static/**"); - assertThat(staticHandler).extracting("locationValues").asList().hasSize(2); + assertThat(staticHandler).extracting("locationValues").asList().hasSize(4); }); } diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/resources/META-INF/resources/webjars/webjar b/spring-boot-project/spring-boot-autoconfigure/src/test/resources/META-INF/resources/webjars/webjar deleted file mode 100644 index e69de29bb2d1..000000000000 diff --git a/spring-boot-project/spring-boot-dependencies/build.gradle b/spring-boot-project/spring-boot-dependencies/build.gradle index 32a02ce8f758..23aef8f021b5 100644 --- a/spring-boot-project/spring-boot-dependencies/build.gradle +++ b/spring-boot-project/spring-boot-dependencies/build.gradle @@ -1663,7 +1663,7 @@ bom { ] } } - library("Spring Framework", "5.3.11") { + library("Spring Framework", "5.3.12-SNAPSHOT") { group("org.springframework") { imports = [ "spring-framework-bom"