Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-image option for image building #21534

Closed
scottfrederick opened this issue May 21, 2020 · 2 comments
Closed

Add run-image option for image building #21534

scottfrederick opened this issue May 21, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@scottfrederick
Copy link
Contributor

scottfrederick commented May 21, 2020

The pack CLI build command supports a run-image option that allows the user to override the run image specified in the builder stack metadata. This option could be useful to users of the Spring Boot Maven plugin spring-boot:build-image goal and Gradle plugin bootBuildImage task.

@scottfrederick scottfrederick added the type: enhancement A general enhancement label May 21, 2020
@scottfrederick scottfrederick added this to the 2.3.x milestone May 21, 2020
@slyoldfox
Copy link

@scottfrederick been experimenting for a day or so with buildpacks. Adding the run-image seems like a good enhancement.

At the moment I seem to be stuck having to create a custom builder, referencing the run-image even though I am not modifying anything else.

Also, is it correct that the builder and run-image need to exist in a remote registry? I was testing locally (without pushing) and was receiving a 404.

pack create-builder docker.io/foo/my-builder --builder-config ./builder/builder.toml

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.3.0.RELEASE:build-image (default-cli) on project demo: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.3.0.RELEASE:build-image failed: Docker API call to 'localhost/v1.24/images/create?fromImage=docker.io%2Ffoo%2Fmy-builder%3Alatest' failed with status code 404 "Not Found" -> [Help 1]

Is this normaly behaviour or have I missed some documentation?

@scottfrederick scottfrederick changed the title Add buildpack and run-image options for image building Add run-image option for image building Jun 5, 2020
@Woodham
Copy link

Woodham commented Jun 11, 2020

This would also solve a problem for us, as we're required to pull images through a corporate docker mirror and there's no way of changing the run image name to be able to do that currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants