Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Data Elasticsearch: Health indicator fails with reactive only configuration #21724

Closed
ractive opened this issue Jun 5, 2020 · 4 comments
Closed

Spring Data Elasticsearch: Health indicator fails with reactive only configuration #21724

ractive opened this issue Jun 5, 2020 · 4 comments
Labels
status: duplicate A duplicate of another issue

Comments

@ractive
Copy link
Contributor

ractive commented Jun 5, 2020

When only a configuration for a ReactiveElasticsearchClient is present (we have created a subclass of AbstractReactiveElasticsearchConfiguration to configure it), the health indicator fails because it uses a default RestClient configured with localhost:9200.

Adding a non-reactive configuration (extending AbstractElasticsearchConfiguration) makes the health check succeed.

My expectation would be that the ElasticsearchRestHealthIndicator uses any rest client configured, also the reactive one.

This happens with Spring Boot 2.3.0 and spring-data-elastisearch 4.0.0.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2020
@bclozel
Copy link
Member

bclozel commented Jun 5, 2020

This looks similar to #21042 - is it @ractive ?

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Jun 5, 2020
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Jun 12, 2020
@ractive
Copy link
Contributor Author

ractive commented Jun 18, 2020

Yes. That's the same issue it seems. You can close this if you want! 👍

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Jun 18, 2020
@bclozel
Copy link
Member

bclozel commented Jun 18, 2020

Thanks @ractive !

@bclozel bclozel closed this as completed Jun 18, 2020
@bclozel bclozel added status: duplicate A duplicate of another issue and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @ractive @spring-projects-issues