Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Kafka metrics support #21910

Closed
hoplers opened this issue Jun 13, 2020 · 2 comments
Closed

Document Kafka metrics support #21910

hoplers opened this issue Jun 13, 2020 · 2 comments
Assignees
@snicoll
Labels
type: documentation A documentation update
Milestone
2.3.2

Comments

@hoplers
Copy link

hoplers commented Jun 13, 2020

Spring Boot 2.3 release notes states that it now supports native consumer & producer metrics (i guess this was implemented here - #20838), but documentation (latest,2.3.0,2.3.1,2.3.2) states that only kafka consumer metrics are supproted natively - for example https://docs.spring.io/spring-boot/docs/2.3.2.BUILD-SNAPSHOT/reference/htmlsingle/#production-ready-metrics-meter
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 13, 2020
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 15, 2020
@snicoll snicoll added this to the 2.3.2 milestone Jun 15, 2020
@snicoll snicoll changed the title Kafka producer metrics support should be added to documentation Document Kafka metrics support Jun 15, 2020
@snicoll snicoll self-assigned this Jun 15, 2020
@snicoll snicoll mentioned this issue Jun 15, 2020
Closed
@snicoll
Copy link
Member

snicoll commented Jun 15, 2020

@hoplers good catch. I've also added a small section to provide additional details and link to Spring Kafka's documentation.

@hoplers
Copy link
Author

hoplers commented Jun 15, 2020

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
2.3.2
Development

No branches or pull requests
3 participants
@snicoll @spring-projects-issues @hoplers