New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spring-boot-starter-parent contains elements that must be overridden and aren't documented as such #21989
Comments
Thank you, @rupert-madden-abbott.
I'm not sure that they are required. We haven't got those in |
Here are the relevant parts of the effective pom for a project using <url>https://projects.spring.io/spring-boot/#/spring-boot-starter-parent/demo</url>
<licenses>
<license>
<name>Apache License, Version 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0</url>
</license>
</licenses>
<developers>
<developer>
<name>Pivotal</name>
<email>info@pivotal.io</email>
<organization>Pivotal Software, Inc.</organization>
<organizationUrl>https://www.spring.io</organizationUrl>
</developer>
</developers>
<scm>
<url>https://github.com/spring-projects/spring-boot/spring-boot-starter-parent/demo</url>
</scm> And here's the equivalent when using 2.3.1: <url>https://spring.io/projects/spring-boot/demo</url>
<organization>
<name>Pivotal Software, Inc.</name>
<url>https://spring.io</url>
</organization>
<licenses>
<license>
<name>Apache License, Version 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0</url>
</license>
</licenses>
<developers>
<developer>
<name>Pivotal</name>
<email>info@pivotal.io</email>
<organization>Pivotal Software, Inc.</organization>
<organizationUrl>https://www.spring.io</organizationUrl>
</developer>
</developers>
<scm>
<connection>scm:git:git://github.com/spring-projects/spring-boot.git/demo</connection>
<developerConnection>scm:git:ssh://git@github.com/spring-projects/spring-boot.git/demo</developerConnection>
<url>https://github.com/spring-projects/spring-boot/demo</url>
</scm>
<issueManagement>
<system>GitHub</system>
<url>https://github.com/spring-projects/spring-boot/issues</url>
</issueManagement> Given how it's used, I think it makes sense to minimise the elements in |
Following the fix for gh-21989, spring-boot-starter-parent no longer contains an <issueManagement> element. As a result the additional content was no longer being added to the pom. This commit updates the additions so that they are now added after the <scm> element that is still present. See gh-21989
Following on from #18532.
There are still some settings (in 2.3.1.RELEASE) getting inherited which need to be overridden but which are not documented:
A complete override would look like this:
However, both organization and issueManagement are not required by Maven central so it would be better to remove them from spring-boot-starter-parent, to eliminate the need for overriding them.
scm developerConnection and connection are required so need adding to the documentation.
The text was updated successfully, but these errors were encountered: