Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty with Conscrypt no longer a requirement for easy HTTP/2 #22188

Closed
joakime opened this issue Jul 1, 2020 · 3 comments
Closed

Jetty with Conscrypt no longer a requirement for easy HTTP/2 #22188

joakime opened this issue Jul 1, 2020 · 3 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@joakime
Copy link

joakime commented Jul 1, 2020

Starting with Java 8u252 (note: not 8u251) the ALPN layer has been backported from Java 11 back to Java 8.

The mandated use of Conscrypt with Jetty for HTTP/2 (in SpringBoot) is now no longer a requirement.
You can use Jetty and HTTP/2 without the need for a bootclasspath or an agent, as long as you use Java 8u252 or newer.

There is also a lack of documentation about how to disable the Conscrypt provider when using Jetty with SpringBoot.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 1, 2020
@bclozel bclozel self-assigned this Jul 1, 2020
@bclozel bclozel added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 1, 2020
@bclozel bclozel added this to the 2.4.x milestone Jul 1, 2020
@bclozel
Copy link
Member

bclozel commented Jul 1, 2020

I'm scheduling this as a documentation improvement for this section of the reference documentation. Depending on the outcome of this, we might also repurpose this issue as an enhancement for removing the conscrypt requirement.

@sunng87
Copy link

sunng87 commented Jul 13, 2020

By the way it's not just a doc change. The Jetty's SslServerCustomizer still requires conscrypt as SSL provider. The conscrypt library has serious memory leak issue. So it would be nice to use JDK based provider or at least configurable.

@philwebb philwebb added type: enhancement A general enhancement and removed type: documentation A documentation update labels Jul 13, 2020
@bclozel bclozel modified the milestones: 2.4.x, 2.3.3 Aug 7, 2020
@bclozel
Copy link
Member

bclozel commented Aug 7, 2020

We've improved the auto-configuration to be more flexible and allow several deployments: JDK9+, JDK8u252+ or Conscrypt. We're also now guiding developers if there's a missing jetty-alpn-*-server dependency. We've updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants