Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reactive Elasticsearch healthcheck with client cluster API #22216

Closed
bclozel opened this issue Jul 3, 2020 · 4 comments
Closed

Update reactive Elasticsearch healthcheck with client cluster API #22216

bclozel opened this issue Jul 3, 2020 · 4 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@bclozel
Copy link
Member

bclozel commented Jul 3, 2020

Once https://jira.spring.io/browse/DATAES-818 is fixed, we can leverage the client cluster API in the reactive healtcheck implementation. See #21042
@bclozel bclozel added type: task A general task status: blocked An issue that's blocked on an external project change labels Jul 3, 2020
@bclozel bclozel added this to the 2.x milestone Jul 3, 2020
@marvedly
Copy link

marvedly commented May 7, 2021 •
edited

Now that that issue that you linked https://jira.spring.io/browse/DATAES-818 has been fixed, do you have any plans of dealing with this soon?

@bclozel bclozel removed the status: blocked An issue that's blocked on an external project change label May 7, 2021
@bclozel bclozel modified the milestones: 2.x, 2.6.x May 7, 2021
@bclozel
Copy link
Member Author

bclozel commented May 7, 2021

@marvedly we're too late in the cycle to release this with 2.5.0, so we're scheduling this for 2.6.x. Thanks!

@snicoll
Copy link
Member

snicoll commented May 7, 2021

FTR we had a PR around that we declined (for another reason) but we also discussed the fact that using the low-level component was more consistent, see #26140

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label May 7, 2021
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-attention An issue we'd like other members of the team to review type: task A general task labels May 19, 2021
@bclozel bclozel removed this from the 2.6.x milestone May 19, 2021
@bclozel
Copy link
Member Author

bclozel commented May 19, 2021

Since this was considered and declined in #26140, let's close this issue as I don't see anything else to be discussed.

@bclozel bclozel closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bclozel @snicoll @marvedly