Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI image build fails if environment has any empty properties #22703

Closed
dsyer opened this issue Aug 3, 2020 · 2 comments
Closed

OCI image build fails if environment has any empty properties #22703

dsyer opened this issue Aug 3, 2020 · 2 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@dsyer
Copy link
Member

dsyer commented Aug 3, 2020

pom.xml:

			<plugin>
				<groupId>org.springframework.boot</groupId>
				<artifactId>spring-boot-maven-plugin</artifactId>
				<configuration>
					<image>
						<env>
							<FOO></FOO>
						</env>
					</image>
				</configuration>
			</plugin>

result:

[ERROR] Failed to execute goal org.springframework.boot:spring-boot-maven-plugin:2.4.0-SNAPSHOT:build-image (default-cli) on project func: Execution default-cli of goal org.springframework.boot:spring-boot-maven-plugin:2.4.0-SNAPSHOT:build-image failed: String must not be null -> [Help 1]
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 3, 2020
@scottfrederick scottfrederick self-assigned this Aug 3, 2020
@scottfrederick scottfrederick added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 3, 2020
@scottfrederick scottfrederick added this to the 2.3.x milestone Aug 3, 2020
@scottfrederick
Copy link
Contributor

@dsyer What are you expecting to happen with your use case - should the empty env entry be ignored or should an entry named FOO be provided to the builder with an empty value? The latter seems appropriate, but I'm wondering if there's something specific that led you to try this.

@dsyer
Copy link
Member Author

dsyer commented Aug 4, 2020

The value is empty so null is a poor representation I would say. Your call. I stumbled on this accidentally, but I wild t expect it to blow up really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants