Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value of server.jetty.accesslog.format is wrongly associated to server.forward-headers-strategy #22921

Closed
cniesen opened this issue Aug 12, 2020 · 1 comment
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@cniesen
Copy link

cniesen commented Aug 12, 2020

The generated documentation for ServerProperties isn't correct.
server.jetty.accesslog.format default should be "ncsa" while
server.forward-headers-strategy should shouldn't have a default. At least I couldn't find in code where that property is initialized.

Relevant code snippets:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 12, 2020
@snicoll
Copy link
Member

snicoll commented Aug 13, 2020

Thanks for the report. This is a polish commit that unfortunately mixed things up

@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 13, 2020
@snicoll snicoll added this to the 2.3.3 milestone Aug 13, 2020
@snicoll snicoll changed the title 2.3.2 Release Documentation Incorrect: Server properties Default value of server.jetty.accesslog.format is wrongly associated to server.forward-headers-strategy Aug 13, 2020
@snicoll snicoll self-assigned this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants