Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring-boot:build-image has a layout parameter that cannot be always be honoured #24105

Closed
wilkinsona opened this issue Nov 10, 2020 · 1 comment
Closed

spring-boot:build-image has a layout parameter that cannot be always be honoured #24105

wilkinsona opened this issue Nov 10, 2020 · 1 comment
Assignees
@scottfrederick
Labels
type: bug A general bug
Milestone
2.3.8

Comments

@wilkinsona
Copy link
Member

The layout and perhaps also the layoutFactory parameters on spring-boot:build-image don't make complete sense. For example, image building is currently limited to jar files yet the layout can be set to war. The parameters are also listed as being since 1.0 and 1.5 respectively, but image building was a new feature in 2.3. Perhaps BuildImageMojo shouldn't extend AbstractPackagerMojo?
@wilkinsona wilkinsona added this to the 2.3.x milestone Nov 10, 2020
@wilkinsona wilkinsona added for: team-attention An issue we'd like other members of the team to review type: bug A general bug labels Nov 10, 2020
@wilkinsona wilkinsona mentioned this issue Nov 10, 2020
Closed
@philwebb
Copy link
Member

We'll move both out of AbstractPackagerMojo and push them to the subclass.

@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Nov 18, 2020
@scottfrederick scottfrederick self-assigned this Jan 7, 2021
@scottfrederick scottfrederick mentioned this issue Jan 7, 2021
Closed
@scottfrederick scottfrederick modified the milestones: 2.3.x, 2.3.8 Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottfrederick scottfrederick

Labels
type: bug A general bug
Projects
None yet
Milestone
2.3.8
Development

No branches or pull requests
3 participants
@scottfrederick @philwebb @wilkinsona