Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kafka 2.6.2 #24247

Closed
snicoll opened this issue Nov 25, 2020 · 19 comments
Closed

Upgrade to Kafka 2.6.2 #24247

snicoll opened this issue Nov 25, 2020 · 19 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Nov 25, 2020

Kafka 2.6.0 is broken as it relies on jackson-databind but the dependency is wrongly flagged as provided. Let's hope they manage to release 2.6.1 in time for our own release.

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Nov 25, 2020
@snicoll snicoll added this to the 2.4.1 milestone Nov 25, 2020
@philwebb
Copy link
Member

philwebb commented Dec 1, 2020

See apache/kafka#9194

@snicoll
Copy link
Member Author

snicoll commented Dec 10, 2020

Unfortunately, 2.6.1 wasn't released in time, moving to the 2.4.x backlog.

@snicoll snicoll modified the milestones: 2.4.1, 2.4.x Dec 10, 2020
@garyrussell
Copy link
Contributor

@snicoll snicoll modified the milestones: 2.4.x, 2.4.2 Jan 7, 2021
@snicoll
Copy link
Member Author

snicoll commented Jan 7, 2021

Thanks Gary. I've updated the milestone accordingly.

@wilkinsona
Copy link
Member

This upgrade breaks Kafka Streams on Windows: https://issues.apache.org/jira/browse/KAFKA-12190. We either need to revert or ignore some tests on Windows. We're leaning towards reverting at the moment.

@wilkinsona wilkinsona reopened this Jan 13, 2021
@garyrussell
Copy link
Contributor

garyrussell commented Jan 13, 2021

Yikes! Wish I'd known that before cutting SK 2.6.5 😦

@garyrussell
Copy link
Contributor

garyrussell commented Jan 13, 2021

In light of the comment on the JIRA about Kafka Streams not being "officially supported" on Windows, I would prefer ignoring the tests on windows, for now, rather than re-introducing the Jackson pain by reverting.

@wilkinsona
Copy link
Member

I'm torn. On the one hand, I don't like getting stuck on older versions of a project. One that other hand, upgrading to 2.6.1 will inconvenience anyone developing with Kafka Streams on Windows even if their production workloads are running on Linux. Anyone already on 2.6.0 will have addressed the Jackson pain so upgrading to 2.6.1 will add more pain for those on Windows. Reverting the upgrade, and thereby staying on 2.6.0, will avoid any additional pain until 2.6.2 is out. I'm still leaning towards reverting.

@snicoll
Copy link
Member Author

snicoll commented Jan 14, 2021

I agree with Andy here. Upgrading would fix a problem that users have already put mitigation in place while introducing a new one. Keeping the status quo seems the less disruptive option to me.

@garyrussell
Copy link
Contributor

OK; I can live with that. Thanks.

snicoll added a commit that referenced this issue Jan 14, 2021
@snicoll snicoll modified the milestones: 2.4.2, 2.4.x Jan 14, 2021
@snicoll
Copy link
Member Author

snicoll commented Jan 14, 2021

Alright, I've reverted in dda8b5d

@wilkinsona
Copy link
Member

I think we should wait and pick up 2.6.2 which, with thanks to @ableegoldman, is now planned for this month (February 2021).

@wilkinsona wilkinsona changed the title Upgrade to Kafka 2.6.1 Upgrade to Kafka 2.6.2 Feb 1, 2021
@snicoll
Copy link
Member Author

snicoll commented Mar 15, 2021

FTR, 2.6.2 is not available yet. @ableegoldman, we're releasing this week, do you have an updated ETA for this release? Thanks!

@ableegoldman
Copy link

The 2.6.2 RC is currently in voting. The deadline is set to this Friday (the 19th) so hopefully it should be ready by the end of this week.

@ableegoldman
Copy link

ableegoldman commented Mar 19, 2021

Hey all, we discovered another blocker at the last minute so I need to roll a new RC for 2.6.2. The new target release date is end of next week (March 26th).

@wilkinsona
Copy link
Member

Thanks for the update, @ableegoldman.

@snicoll snicoll added the status: blocked An issue that's blocked on an external project change label Apr 21, 2021
@ableegoldman
Copy link

Hah, you beat me to it. I was hovering over the Comment button with the good news when your comment showed up 😂

@ableegoldman
Copy link

Thanks for your patience, and sorry for the looong wait.

@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label Apr 22, 2021
@snicoll snicoll self-assigned this Apr 22, 2021
@snicoll snicoll modified the milestones: 2.4.x, 2.4.6 Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

5 participants