Exceptions are still translated by JdbcTransactionManager when spring.dao.exceptiontranslation.enabled is false

[Gama11]

We ran into an issue with the 2.4.0 release because it replaced DataSourceTransactionManager with JdbcTransactionManager. The latter does exception translation:

• Use JdbcTransactionManager in favor of DatasourceTransactionManager #23572 / 9293b26
• DataSourceTransactionManager does not consider SQLExceptionTranslator on commit spring-framework#24064 (comment)

This led to a DuplicateKeyException exception being thrown rather than a TransactionSystemException. We didn't expect this because we had explicitly disabled exception translation:

spring.dao.exceptiontranslation.enabled=false

Perhaps DataSourceTransactionManager should continue to be used if this property is set to false?

[snicoll]

Thanks for the report @Gama11. I overlooked that property when I did that change.

[wilkinsona]

Please see #24867 for details of a refinement that will be made to the fix for this issue. It should be available in 2.4.3.