Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application properties in 2.4 vs 2.3 #24423

Closed
carlmendoza opened this issue Dec 9, 2020 · 6 comments
Closed

Application properties in 2.4 vs 2.3 #24423

carlmendoza opened this issue Dec 9, 2020 · 6 comments
Labels
for: external-project For an external project and not something we can fix

Comments

@carlmendoza
Copy link

Hi, just wondering if there are any other changes from Spring boot 2.3 -> 2.4? I am currently in the process of migrating a project but there seems to be an issue around trying to access a Microsoft SQL DB via AAD:

020-12-08T16:22:51.535920980Z ERROR [2020-12-343 16:22:51.535] [user: -] [cid: -] [main] [c.z.h.p.HikariPool] - HikariPool-1 - Exception during pool initialization. 2020-12-08T16:22:51.535952880Z com.microsoft.sqlserver.jdbc.SQLServerException: Failed to authenticate the user xxx in Active Directory (Authentication=ActiveDirectoryPassword).

the credentials are passed using application properties as normal and did not have any blank # lines that would have messed up parsing this file although there is a double space, not sure if that is the issue.

I also added the new flag spring.config.use-legacy-processing = true but its underlined on intellij with cannot resolve configuration property?

I ran the application using 2.3 and 4, and it seems to work with 2.3 but returns the error above when upgrading to 2.4.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 9, 2020
@mbhave
Copy link
Contributor

mbhave commented Dec 9, 2020

@carlmendoza There were quite a few changes related to the way config files are processed between 2.3 and 2.4. But since you've switched on the spring.config.use-legacy-processing flag, those changes shouldn't affect you. Do you have a small, minimal sample that we can run to reproduce the issue?

@mbhave mbhave added the status: waiting-for-feedback We need additional information before we can continue label Dec 9, 2020
@carlmendoza
Copy link
Author

carlmendoza commented Dec 10, 2020

Hi @mbhave thanks for the response, I dont have a small example at the moment unfortunately. However, just wanted to check that double break lines between variables in application.properties shouldn't affect parsing of the field values.

Apologies for being a bit vague, just wanted to double check the application.properties I have complies with 2.4 before I delve into other potential causes of this error. Thanks!

@carlmendoza
Copy link
Author

I will see if I can provide more info tomorrow.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 10, 2020
@mbhave mbhave added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Dec 10, 2020
@mbhave
Copy link
Contributor

mbhave commented Dec 10, 2020

We fixed a bug related to property file processing in 2.4.1 which will be released tomorrow. In the meantime, you could try the 2.4.1 snapshots to see if that fixes your issues. If that is not the issue, a sample would be great.

@carlmendoza
Copy link
Author

thanks @mbhave, I will try tomorrow.. is 2.4.1-SNAPSHOT on mvn, would be a quick update on our poms if it is, otherwise its fine, can create a new proj from scratch.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 10, 2020
@wilkinsona wilkinsona added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Dec 10, 2020
@carlmendoza
Copy link
Author

closing this - the issue was with our Azure dependencies which doesn't work well with 2.4 yet, see workaround here https://docs.microsoft.com/en-us/azure/spring-cloud/spring-cloud-faq?pivots=programming-language-java#development

Thanks for your time @mbhave

@scottfrederick scottfrederick added for: external-project For an external project and not something we can fix and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix
Projects
None yet
Development

No branches or pull requests

5 participants