New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starter jars not excluded from repackaged jars using spring-boot-maven-plugin. #24594
Comments
Nice find @edwardsre. If I remember correctly, my original PR for this included a catch on every Exception - not just IOException - which the Gradle part still does for example: see JarTypeFileSpec. I guess the third alternative is to harmonize this on the Maven side of things. I'd be happy to open a PR if you don't mind to fix this, but I don't want to steal your chance to provide a PR yourself. Just let me know. |
JarTypeFilter was not handling dependency jars with missing manifest files, resulting in all starter jars being included in repackaged jars. Fixes spring-projectsgh-24594
Thanks @dreis2211. I submitted a PR using the Optional approach. |
Very nice @edwardsre, thank you very much for the detective work and the PR. @dreis2211 thanks for the follow-up, it is very much appreciated. Closing in favour of PR #24597 |
JarTypeFilter
is not handling dependency jars with missing manifest files. This results in all starter jars being included in the repackaged jar.A
NullPointerException
is thrown fromJarTypeFilter.filter
on this line:When this occurs, the NPE is caught in
FilterArtifacts.filter
which skips the results of the executing filter, resulting in the starter jars being retained in the repackaged jar file.If the manifest file is missing, the jar should still be included by this filter (returning false). Either of these fix the issue...
or
This jar was the culprit in our project.
net.sourceforge.streamsupport:streamsupport:1.2.1
.The text was updated successfully, but these errors were encountered: