Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring a user-defined WebServerFactory should make sure the auto-configuration backs off #24706

Open
snicoll opened this issue Jan 8, 2021 · 3 comments
Labels
status: on-hold We can't start working on this issue yet type: enhancement A general enhancement

Comments

@snicoll
Copy link
Member

snicoll commented Jan 8, 2021

See #24705

We initially designed things this way because we wanted an easy way for users to opt-in for the embedded server of their choices if they happen to have two on the classpath and the one the auto-configuration picked was not the one they wanted to use.

This corner case makes the auto-configuration at odds with others. If you register a WebServerFactory the customizers are applied anyway. This means also that whatever you configure in the factory itself is likely to be lost since default opinions are going to be applied after that.

Changing this behaviour is a breaking change that could surprise more than one user. We may want to keep the current behaviour , perhaps using a configuration property. This would help users to migrate.

@wagnerluis1982
Copy link
Contributor

Hi, is this open for contributors? If yes, I'd like to be assigned to it.

@scottfrederick
Copy link
Contributor

@wagnerluis1982 Thanks for the offer. This issue is assigned to the 3.x milestone, and we will not be ready to accept contributions for that milestone until we've cut branches and gotten some infrastructure ready for it.

@scottfrederick scottfrederick added the status: blocked An issue that's blocked on an external project change label Nov 1, 2021
@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Apr 26, 2022
@philwebb philwebb added status: on-hold We can't start working on this issue yet and removed status: blocked An issue that's blocked on an external project change for: team-meeting An issue we'd like to discuss as a team to make progress labels Jun 13, 2022
@philwebb philwebb modified the milestones: 3.x, General Backlog Jun 13, 2022
@philwebb
Copy link
Member

We've decided that whilst we might want to tackle this at some point, we don't want to add complications for people upgrading from Boot 2.x to 3.0.x. Since we've not had that many complaints from the community, we think it might be better to take this on at a point release where it will be easier for users to spot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on-hold We can't start working on this issue yet type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants