Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main application.yaml overrides test application.properties #24719

Closed
alexalbr opened this issue Jan 10, 2021 · 2 comments
Closed

main application.yaml overrides test application.properties #24719

alexalbr opened this issue Jan 10, 2021 · 2 comments
Assignees
@mbhave
Labels
type: regression A regression from a previous release
Milestone
2.4.2

Comments

@alexalbr
Copy link

Since Spring Boot 2.4 values in test application.properties are not used, if the same property exists in an application.yaml file in the main directory.
The attached demo project shows the issue. It works as expected when the spring.config.use-legacy-processing=true property is active

demo.zip
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 10, 2021
@mbhave mbhave added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 11, 2021
@mbhave mbhave added this to the 2.4.x milestone Jan 11, 2021
@mbhave
Copy link
Contributor

mbhave commented Jan 11, 2021

Thanks for the sample @alexalbr. The order in which .properties and .yaml files are processed appears to have switched in 2.4.

@wilkinsona wilkinsona added type: regression A regression from a previous release type: bug A general bug and removed type: bug A general bug type: regression A regression from a previous release labels Jan 12, 2021
@mbhave mbhave added type: regression A regression from a previous release and removed type: bug A general bug labels Jan 12, 2021
@mbhave mbhave self-assigned this Jan 12, 2021
@mbhave mbhave added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 12, 2021
@encircled
Copy link
Contributor

Duplicate #24497

@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 13, 2021
mbhave added a commit to mbhave/spring-boot that referenced this issue Jan 13, 2021
@mbhave
Fix ordering of properties and yaml files
d7f9920 
Fixes spring-projectsgh-24719
@mbhave mbhave mentioned this issue Jan 13, 2021
Closed
@mbhave mbhave closed this as completed in ceff47a Jan 13, 2021
@snicoll snicoll modified the milestones: 2.4.x, 2.4.2 Jan 14, 2021
@philwebb philwebb mentioned this issue Feb 5, 2021
Closed
andymarke added a commit to ministryofjustice/community-api that referenced this issue Feb 16, 2021
@andymarke
DT-1574 remove legacy property switch now spring-projects/spring-boot…
432cdab 
…#24719 is resolved
mikehalmamoj pushed a commit to ministryofjustice/community-api that referenced this issue Feb 16, 2021
@andymarke
DT-1574 remove legacy property switch now spring-projects/spring-boot…
b4d1aa7 
…#24719 is resolved (#368)
minwoox added a commit to minwoox/armeria that referenced this issue May 26, 2023
@minwoox
Remove spring.config.use-legacy-processing in tests
763aa42 
Motivation:
When we upgrade to Spring Boot 2.4, we used `spring.config.use-legacy-processing` property because main application.yml overrides the yaml files in test.
However, it was a bug and fixed.
spring-projects/spring-boot#24719
Therefore, we don't have to use `spring.config.use-legacy-processing` anymore.

Modifications:
- Remove `spring.config.use-legacy-processing` property

Result:
- Close line#4899
@minwoox minwoox mentioned this issue May 26, 2023
Merged
ikhoon pushed a commit to line/armeria that referenced this issue Jun 2, 2023
@minwoox
Remove spring.config.use-legacy-processing in tests (#4900)
7d731ec 
Motivation:
When we upgrade to Spring Boot 2.4, we used `spring.config.use-legacy-processing` property because main application.yml overrides the yaml files in the test. However, it was a bug and was fixed.
spring-projects/spring-boot#24719 Therefore, we don't have to use `spring.config.use-legacy-processing` anymore.

Modifications:
- Remove `spring.config.use-legacy-processing` property

Result:
- Close #4899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhave mbhave

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
2.4.2
Development

No branches or pull requests
7 participants
@snicoll @philwebb @wilkinsona @encircled @mbhave @spring-projects-issues @alexalbr