Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default spring.mvc.pathmatch.matching-strategy #24805

Closed
philwebb opened this issue Jan 13, 2021 · 6 comments
Closed

Switch default spring.mvc.pathmatch.matching-strategy #24805

philwebb opened this issue Jan 13, 2021 · 6 comments
Assignees
@mbhave
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone
2.6.0-M3

Comments

@philwebb
Copy link
Member

We could upgrade to the new PathPattern based solution now.
@philwebb philwebb added this to the 2.5.x milestone Jan 13, 2021
@philwebb philwebb added the type: enhancement A general enhancement label Jan 13, 2021
@philwebb philwebb mentioned this issue Jan 13, 2021
Closed
@wilkinsona wilkinsona added the status: noteworthy A noteworthy issue to call out in the release notes label Jan 18, 2021
@wilkinsona
Copy link
Member

#24874 and #24877 need to be addressed before we can tackle this one.

@philwebb philwebb self-assigned this Jan 20, 2021
@philwebb philwebb mentioned this issue Jan 21, 2021
Closed
@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Jan 21, 2021
@philwebb
Copy link
Member Author

Also blocked on spring-projects/spring-framework#26415

@bclozel
Copy link
Member

bclozel commented Jan 21, 2021

We're also fixing spring-projects/spring-framework#26411 in the upcoming Spring Framework 5.3.4 release.

@philwebb philwebb mentioned this issue Jan 21, 2021
Closed
@philwebb philwebb removed the status: blocked An issue that's blocked on an external project change label Mar 8, 2021
@philwebb
Copy link
Member Author

philwebb commented Apr 7, 2021

See also spring-projects/spring-framework#26445 which should allow us to relax the servlet path check

@philwebb philwebb modified the milestones: 2.5.x, 2.5.0-RC1 Apr 7, 2021
philwebb added a commit that referenced this issue Apr 7, 2021
@philwebb
Allow 'servet.path' with path pattern parser
455864b 
Remove the restriction previously prevented `spring.mvc.servlet.path`
from being combined with a `spring.mvc.pathmatch.matching-strategy`
of `PATH_PATTERN_PARSER`. Spring Framework supports this combination
as of v5.3.4.

See gh-24805
@philwebb philwebb mentioned this issue Apr 7, 2021
Closed
@philwebb philwebb reopened this Apr 7, 2021
@philwebb
Copy link
Member Author

philwebb commented Apr 7, 2021

Fails due to spring-projects/spring-framework#26775

philwebb added a commit that referenced this issue Apr 7, 2021
@philwebb
Revert "Switch default MVC path matching strategy"
e766c8b 
This reverts commit ab8e599.

See gh-24805
@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Apr 7, 2021
@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label Apr 13, 2021
@philwebb philwebb reopened this Apr 16, 2021
@philwebb
Copy link
Member Author

Reopening due to spring-projects/spring-framework#26814

@philwebb philwebb added the status: blocked An issue that's blocked on an external project change label Apr 16, 2021
@philwebb philwebb modified the milestones: 2.5.0-RC1, 2.6.x Apr 16, 2021
philwebb added a commit that referenced this issue Apr 16, 2021
@philwebb
Revert "Switch default MVC path matching strategy"
a48c98b 
This reverts commit ab8e599.

See gh-24805
@philwebb philwebb removed the status: blocked An issue that's blocked on an external project change label Apr 17, 2021
@philwebb philwebb removed their assignment Aug 12, 2021
@mbhave mbhave self-assigned this Aug 31, 2021
@mbhave mbhave closed this as completed in 2d89a82 Sep 2, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.0-M3 Sep 5, 2021
@william00179 william00179 mentioned this issue Dec 1, 2021
Closed
@Shterneregen Shterneregen mentioned this issue Jan 19, 2022
Merged
@ryanjbaxter ryanjbaxter mentioned this issue Feb 15, 2022
Closed
@rstoyanchev rstoyanchev mentioned this issue Jun 10, 2022
Closed
@yaoxuwan yaoxuwan mentioned this issue Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhave mbhave

Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Milestone
2.6.0-M3
Development

No branches or pull requests
5 participants
@bclozel @snicoll @philwebb @wilkinsona @mbhave