Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DockerApi to support configured authentication #25898

Open
philwebb opened this issue Apr 7, 2021 · 3 comments
Open

Update DockerApi to support configured authentication #25898

philwebb opened this issue Apr 7, 2021 · 3 comments
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Apr 7, 2021

We're currently hitting rate limit issues with our tests due to the fact that the Docker config.json files is not read. We should ideally add support to our DockerApi class.

Some references to consider when implementing:

https://github.com/testcontainers/testcontainers-java/blob/bc48eebeefb344b0878637c021b8a1998ff4d677/core/src/main/java/org/testcontainers/utility/RegistryAuthLocator.java

https://github.com/docker-java/docker-java/blob/0306031832432454fbbdbf5c20e16fe881c7b065/docker-java-core/src/main/java/com/github/dockerjava/core/DockerConfigFile.java#L50

@philwebb philwebb added this to the 2.5.x milestone Apr 7, 2021
@philwebb philwebb added the type: enhancement A general enhancement label Apr 7, 2021
@philwebb
Copy link
Member Author

philwebb commented Apr 7, 2021

See also #25838

@dreis2211
Copy link
Contributor

I guess we can close #25889 in that case given that you have a more concrete suggestion here.

@scottfrederick
Copy link
Contributor

When implementing this, we'll have to consider how authentication in a config.json file works with authentication provided in the Maven or Gradle build configuration - for example, which one takes precedence.

config.json allows authentication to be configured for each Docker registry, based on the registry in the image reference. This could be the way to implement #24547 also.

@philwebb philwebb modified the milestones: 2.5.x, 2.6.x Apr 12, 2021
@philwebb philwebb added the status: pending-design-work Needs design work before any code can be developed label Apr 12, 2021
sdeleuze added a commit to spring-attic/spring-native that referenced this issue May 5, 2021
Due to Docker rate limit issue, we will restore them when spring-projects/spring-boot#25898
will be fixed.
@philwebb philwebb modified the milestones: 2.6.x, 2.x Oct 13, 2021
@philwebb philwebb modified the milestones: 2.x, 3.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants