Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationAvailabilityBean should log at debug level #26624

Closed
philwebb opened this issue May 21, 2021 · 1 comment
Closed

ApplicationAvailabilityBean should log at debug level #26624

philwebb opened this issue May 21, 2021 · 1 comment
Labels
type: bug A general bug
Milestone

Comments

@philwebb
Copy link
Member

We added more logging in #23098 at INFO but I wonder if DEBUG might be better.

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label May 21, 2021
@snicoll
Copy link
Member

snicoll commented May 25, 2021

On a command-line app, upgrading lead to the following:

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::                (v2.5.0)

2021-05-25 14:54:03.391  INFO 33405 --- [           main] o.s.release.checklist.Application        : Starting Application using Java 11.0.7 on snicoll-a01.vmware.com with PID 33405 (/Users/snicoll/tools/releases/boot-release/spring-release-checklist.jar started by snicoll in /Users/snicoll/tools/releases/boot-release)
2021-05-25 14:54:03.393  INFO 33405 --- [           main] o.s.release.checklist.Application        : The following profiles are active: release-env,2.4.x
2021-05-25 14:54:03.970  INFO 33405 --- [           main] o.s.release.checklist.Application        : Started Application in 0.96 seconds (JVM running for 1.342)
2021-05-25 14:54:03.971  INFO 33405 --- [           main] o.s.b.a.ApplicationAvailabilityBean      : Application availability state LivenessState changed to CORRECT
2021-05-25 14:54:04.069  INFO 33405 --- [           main] o.s.r.c.ReleaseCheckListGenerator        :
========================================
Generated checklist at /Users/snicoll/tools/releases/boot-release/spring-boot-2.4.5.adoc
========================================
2021-05-25 14:54:04.070  INFO 33405 --- [           main] o.s.b.a.ApplicationAvailabilityBean      : Application availability state ReadinessState changed to ACCEPTING_TRAFFIC

+1 for moving these to debug.

@philwebb philwebb added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review labels May 25, 2021
@philwebb philwebb changed the title Reconsider log level for ApplicationAvailabilityBean ApplicationAvailabilityBean should log at debug level May 25, 2021
@philwebb philwebb modified the milestones: 2.5.x, 2.5.1 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants