LoggingSystem not available on shutdown to log DisposableBean#destroy invocations

[HaojunRen]

I run Spring Boot 2.5.0 application in Spring Tool Suite (Version: 3.9.7.RELEASE). Stopping that application by STS 'stop' button, I find destroy of DisposableBean not excuted. If I return to Spring Boot 2.4.x or 2.3.x, the function will be fine.

Is it an issue or be lated with Spring Tool Suite? Refer to my code, in 2.5.0, ‘Shutting down...’ loggger won't print...

public class MyOperation implements DisposableBean {

    private static final Logger LOG = LoggerFactory.getLogger(MyOperation.class);

    @Override
    public void destroy() throws Exception {
        LOG.info("Shutting down...");
    }

}

[HaojunRen]

example.zip

Please try this example, 'DisposableBean' is called, but log does not output in STS with Spring Boot 2.5.0, BUT can output in 2.4.x, 2.3.x

[snicoll]

Thanks. Something changed in Spring Boot 2.5.0 that stops the LoggingSystem early potentially. That has no impact on calling DisposableBean so I've renamed the issue accordingly.

[HaojunRen]

OK, thanks very much

[philwebb]

With Spring Boot 2.5 we change the logging system to always register a shutdown hook (See #25046). What's happening now is that when the app terminates both the logging system and the ApplicationContext are shutdown. That happens in parallel so it's possible for the logging system to be closed before the disposable beans have had a chance to add logging.

[philwebb]

Fixing this one is a bit tricky. I have something on this branch, but I'd like someone else from the team to review it.

It works by tracking ApplicationContexts that are started in a weak map then checking them all for isActive() false before calling the real shutdown hook.