Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom username/password properties are not picked up by DataSourceInitializationConfiguration #26676

Closed
philwebb opened this issue May 26, 2021 · 1 comment
Assignees
Labels
type: regression A regression from a previous release
Milestone

Comments

@philwebb
Copy link
Member

The determineDataSource doesn't return the build result so the custom username/passwords are not applied. DataSourceInitializationIntegrationTests would have caught this had it not been for the fact that #26644 was causing a ClassCastException rather than the expected "invalid authorization" error.

@philwebb philwebb added the type: regression A regression from a previous release label May 26, 2021
@philwebb philwebb self-assigned this May 26, 2021
@philwebb philwebb added this to the 2.5.x milestone May 26, 2021
@philwebb philwebb modified the milestones: 2.5.x, 2.5.1 May 26, 2021
@philwebb philwebb reopened this May 27, 2021
@philwebb
Copy link
Member Author

philwebb commented May 27, 2021

Reopening because the org.springframework.boot.autoconfigure.sql.init.DataSourceInitializationConfiguration class has the same issue as does org.springframework.boot.autoconfigure.sql.init.R2dbcInitializationConfiguration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

1 participant