Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpringApplicationBuilder constructor with ResourceLoader parameter #26688

Closed
jaminh opened this issue May 28, 2021 · 1 comment
Closed

Add SpringApplicationBuilder constructor with ResourceLoader parameter #26688

jaminh opened this issue May 28, 2021 · 1 comment
Labels
status: superseded An issue that has been superseded by another

Comments

@jaminh
Copy link
Contributor

jaminh commented May 28, 2021

It would be helpful to have a consturctor for the SpringApplicationBuilder that allows passing a custom ResourceLoader when a different classloader needs to be used for the SpringApplication. There is a method for setting the ResourceLoader after construction but this means the spring factories instances have already been initialized with the default classloader rather than the classloader from the ResourceLoader.

The issue #26126 presents a likely scenario where this might be desired.

@snicoll
Copy link
Member

snicoll commented May 28, 2021

As I've indicated on the other issue, we don't need a PR and an issue for the same thing. Considering that you've submitted a proposal, let's continue the discussion there (#26690)

@snicoll snicoll closed this as completed May 28, 2021
@snicoll snicoll added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Development

No branches or pull requests

3 participants