Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionFactoryBuilder.derivefrom should be named derivedFrom to align with DataSourceBuilder #26810

Closed
snicoll opened this issue Jun 8, 2021 · 1 comment
Closed

ConnectionFactoryBuilder.derivefrom should be named derivedFrom to align with DataSourceBuilder #26810

snicoll opened this issue Jun 8, 2021 · 1 comment
Labels
type: bug A general bug
Milestone
2.5.1

Comments

@snicoll
Copy link
Member

snicoll commented Jun 8, 2021

Should be deriveFrom.
@snicoll snicoll added the type: bug A general bug label Jun 8, 2021
@snicoll snicoll added this to the 2.5.x milestone Jun 8, 2021
@snicoll snicoll changed the title Type in ConnectionFactoryBuilder#derivefrom Typo in ConnectionFactoryBuilder#derivefrom Jun 8, 2021
@philwebb
Copy link
Member

philwebb commented Jun 8, 2021

We should align with DataSourceBuilder which uses derivedFrom

@philwebb philwebb changed the title Typo in ConnectionFactoryBuilder#derivefrom ConnectionFactoryBuilder.derivefrom should be named derivedFrom to align with DataSourceBuilder Jun 8, 2021
@philwebb philwebb modified the milestones: 2.5.x, 2.5.1 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.5.1
Development

No branches or pull requests
2 participants
@snicoll @philwebb