Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency management for Prometheus's Pushgateway is incomplete #27349

Closed
wilkinsona opened this issue Jul 15, 2021 · 2 comments
Closed

Dependency management for Prometheus's Pushgateway is incomplete #27349

wilkinsona opened this issue Jul 15, 2021 · 2 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@wilkinsona
Copy link
Member

Actuator depends on TextFormat from io.prometheus:simpleclient_common but we only have dependency management for io.prometheus.simpleclient_pushgateway. We should provide dependency management for all of the client's modules. There's a bom that we can use to do that rather than listing them all individually.

The incomplete dependency management is really a bug. Ideally, we'd fix it in Spring Boot 2.4.x. Our current gateway-only dependency management is in a library named "Prometheus PushGateway" with the version property prometheus-pushgateway.version. We need to broaden this to something like "Prometheus Java Client" and, therefore, prometheus-java-client.version, but this will be a breaking change if we replace one with the other. Having both isn't really an option either as overriding one version property and not the other may give unexpected results.

Perhaps we should just make the change in 2.6 where the breaking change to the property name can then be documented in the release notes. Flagging for team attention to see what everyone else thinks.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jul 15, 2021
@wilkinsona
Copy link
Member Author

wilkinsona commented Jul 15, 2021

And after writing the above, a better way to deal with it has just occurred to me. We can expand the dependency management in 2.4 and 2.5 and then rename it in 2.6.

@wilkinsona wilkinsona added type: bug A general bug and removed for: team-attention An issue we'd like other members of the team to review labels Jul 15, 2021
@wilkinsona wilkinsona added this to the 2.4.x milestone Jul 15, 2021
@wilkinsona wilkinsona changed the title Provide complete dependency management for Prometheus's Java client Dependency management for Prometheus's Pushgateway is incomplete Jul 15, 2021
@wilkinsona wilkinsona self-assigned this Jul 15, 2021
@wilkinsona
Copy link
Member Author

The bom's new in 0.10.0 so let's fix this in 2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant