Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseInitializerDetector and DependsOnDatabaseInitializationDetector implementations may be instantiated with the wrong ClassLoader #27422

Closed
jaminh opened this issue Jul 21, 2021 · 1 comment
Labels
type: bug A general bug
Milestone

Comments

@jaminh
Copy link
Contributor

jaminh commented Jul 21, 2021

I'm sorry this is becoming a game of whack-a-mole but I have found another instance of an alternate classloader not being propagated properly similar to #27133.

The offending line can be found here:

This is leading to a ClassNotFound exception on the FlywayDatabaseInitializerDetector class.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 21, 2021
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 21, 2021
@wilkinsona wilkinsona changed the title DatabaseInitializationDependencyConfigurer not using correct classloader DatabaseInitializerDetector and DependsOnDatabaseInitializationDetector implementations may be instantiated with the wrong ClassLoader Jul 21, 2021
@wilkinsona wilkinsona added this to the 2.5.3 milestone Jul 21, 2021
@jaminh
Copy link
Contributor Author

jaminh commented Jul 22, 2021

It appears after this fix I was able to get spring boot running with an alternate classloader. The only small issue outstanding is the LoggingSystemShutdownListener in the spring cloud project. I am able to work around that issue but I proposed a fix here spring-cloud/spring-cloud-commons#972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants