Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kotlin 1.6.0 #28698

Closed
snicoll opened this issue Nov 16, 2021 · 7 comments
Closed

Upgrade to Kotlin 1.6.0 #28698

snicoll opened this issue Nov 16, 2021 · 7 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Nov 16, 2021

Supersedes #28577

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Nov 16, 2021
@snicoll snicoll added this to the 2.6.0 milestone Nov 16, 2021
@hennr
Copy link

hennr commented Nov 20, 2021

Hi @snicoll ,
sorry if I am getting something wrong here, but I just saw that the spring-boot-dependencies artifact on mvn central still uses kotlin.version 1.5.31:
https://search.maven.org/artifact/org.springframework.boot/spring-boot-dependencies/2.6.0/pom

The SB 2.6.0 release notes (https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.6-Release-Notes#upgrading-from-spring-boot-25) state that kotlin 1.6.0 is used now though.

Is this a bug or don't I get something correctly here?

@bclozel
Copy link
Member

bclozel commented Nov 20, 2021

@hennr This file shows the following line for me:

<kotlin.version>1.6.0</kotlin.version>
</properties>
<!-- ... -->
<dependency>
  <groupId>org.jetbrains.kotlin</groupId>
  <artifactId>kotlin-bom</artifactId>
  <version>${kotlin.version}</version>
  <type>pom</type>
  <scope>import</scope>
</dependency>

@hennr
Copy link

hennr commented Nov 22, 2021

It does indeed!
Strange, so the maven central web-ui seems broken in some way then:

https://search.maven.org/artifact/org.springframework.boot/spring-boot-dependencies/2.6.0/pom
grafik

@wilkinsona
Copy link
Member

Indeed. When I first go to the page, no source is shown for the pom. If I switch to 2.5.7, it shows the source for 2.5.7's pom. Switching back to 2.6.0 then continues to show the source for 2.5.7. Can you please report this to Sonatype?

@hennr
Copy link

hennr commented Nov 23, 2021

@wilkinsona , sure, here you go
sonatype-nexus-community/search-maven-org#159

One more question though: Could you check if the artifact upload was completely successful on your end?

I have the exact same behaviour that you described, but what's bugging me is that a click on browse in upper right corner succeeds but a click on the download button fails with a 404.

@wilkinsona
Copy link
Member

The two are different URLs:

I would avoid using search.maven.org when trying to check Maven Central's contents. Going directly to repo1.maven.org is, IMO, the right thing to do as it eliminates the possibility of search.maven.org causing the problem either due to a bug or because its index is stale.

@hennr
Copy link

hennr commented Dec 1, 2021

It's been a caching problem on search.maven.org and it's shown correctly now, see sonatype-nexus-community/search-maven-org#159 for details.
Thanks for your time and input on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

4 participants