Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that Springfox is incompatible with PathPattern-based path matching #28769

Closed
quaff opened this issue Nov 22, 2021 · 1 comment
Closed
Labels
type: wiki-documentation A documentation update required on the wiki

Comments

@quaff
Copy link
Contributor

quaff commented Nov 22, 2021

Springfox doesn't support PathPatternParser, according to https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.6-Release-Notes#pathpattern-based-path-matching-strategy-for-spring-mvc, we can set spring.mvc.pathmatch.matching-strategy=ant-path-matcher to revert the changes, It works fine.

but it fails if spring-boot-starter-actuator present, I guess it cause by actuator endpoints do not respect spring.mvc.pathmatch.matching-strategy:

The actuator endpoints now also use PathPattern based URL matching.

see springfox/springfox#3934

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 22, 2021
@wilkinsona wilkinsona added type: wiki-documentation A documentation update required on the wiki and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 22, 2021
@wilkinsona
Copy link
Member

wilkinsona commented Nov 22, 2021

This has been a known limitation of Springfox for over a year. Unfortunately, we can't continue to make compromises in Boot to maintain compatibility with a library that doesn't appear to be maintained any more. As suggested by @hpoettker, I've updated the release notes to mention the compatibility problem and link to the Springfox issue.

@wilkinsona wilkinsona changed the title Path matching breaks compatibility even spring.mvc.pathmatch.matching-strategy=ant-path-matcher Note that Springfox is incompatible with PathPattern-based path matching Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: wiki-documentation A documentation update required on the wiki
Projects
None yet
Development

No branches or pull requests

3 participants