Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSourceScriptDatabaseInitializer may still try to access the database even though its initialization mode is never #28931

Closed
wilkinsona opened this issue Dec 8, 2021 · 2 comments
Closed

DataSourceScriptDatabaseInitializer may still try to access the database even though its initialization mode is never #28931

wilkinsona opened this issue Dec 8, 2021 · 2 comments
Assignees
@snicoll
Labels
type: bug A general bug
Milestone
2.6.2

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: bug A general bug label Dec 8, 2021
@wilkinsona wilkinsona added this to the 2.5.x milestone Dec 8, 2021
@wilkinsona wilkinsona mentioned this issue Dec 8, 2021
Closed
@snicoll
Copy link
Member

snicoll commented Dec 13, 2021

I am looking at this issue and I am not able to reproduce the problem in a unit test. I can see the isEnabled check inconsistency with AbstractDataSourceInitializer but I fail to see where the DataSource would be accessed to resolve the scripts. AbstractScriptDatabaseInitializer does not have @@platform@@ support as far as I can see...

I can move the check to make it more consistent but I'd like someone else to have a look in case I missed something.

@snicoll snicoll self-assigned this Dec 13, 2021
@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review and removed for: team-attention An issue we'd like other members of the team to review labels Dec 13, 2021
@snicoll snicoll modified the milestones: 2.5.x, 2.6.2 Dec 14, 2021
@snicoll snicoll changed the title AbstractScriptDatabaseInitializer may still try to access the database even though its initialization mode is never DataSourceScriptDatabaseInitializer may still try to access the database even though its initialization mode is never Dec 14, 2021
@snicoll
Copy link
Member

snicoll commented Dec 14, 2021 •
edited

I think 2.5.x is fine and the regression is in 2.6.x where we use DataSourceScriptDatabaseInitializer and its settings are computed upfront. I'll edit the title of the issue accordingly.

@snicoll snicoll mentioned this issue Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.6.2
Development

No branches or pull requests
2 participants
@snicoll @wilkinsona