Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationPropertySources.attach will always reattach when called multiple times #29409

Closed
philwebb opened this issue Jan 15, 2022 · 0 comments
Closed

ConfigurationPropertySources.attach will always reattach when called multiple times #29409

philwebb opened this issue Jan 15, 2022 · 0 comments
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
2.5.9

Comments

@philwebb
Copy link
Member

The logic in the attach method of ConfigurationPropertySources is wrong casing it to always reattach.
@philwebb philwebb added the type: bug A general bug label Jan 15, 2022
@philwebb philwebb self-assigned this Jan 15, 2022
@philwebb philwebb modified the milestones: 2.5.x, 2.5.9 Jan 15, 2022
@philwebb philwebb mentioned this issue Jan 15, 2022
Closed
philwebb added a commit that referenced this issue Jan 15, 2022
@philwebb
Refine ConfigurationPropertySources attach logic
bccc9c1 
Refine `ConfigurationPropertySources.attach` logic to endure that
the attached or reattached source is always first.

See gh-29409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
1 participant
@philwebb