Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spring Kafka 2.8.3 #29722

Closed
snicoll opened this issue Feb 10, 2022 · 5 comments
Closed

Upgrade to Spring Kafka 2.8.3 #29722

snicoll opened this issue Feb 10, 2022 · 5 comments
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Feb 10, 2022

No description provided.

@snicoll snicoll added the type: dependency-upgrade A dependency upgrade label Feb 10, 2022
@snicoll snicoll added this to the 2.6.4 milestone Feb 10, 2022
@snicoll
Copy link
Member Author

snicoll commented Feb 11, 2022

@garyrussell I can see that setBatchErrorHandler and setErrorHandler have been deprecated. Spring Boot does look for both a BatchErrorHandler and a ErrorHandler and sets those accordingly.

What is our best migration path? Introducing the lookup to CommonErrorHandler in a maintenance release feels unusual to me.

@wilkinsona
Copy link
Member

wilkinsona commented Feb 11, 2022

We added support for CommonErrorHandler in #27927. I think we should just suppress the deprecation warnings for ErrorHandler and BatchErrorHandler while people migrate to CommonErrorHandler.

@garyrussell
Copy link
Contributor

This change was introduced (in 2.8) to allow a common (auto configured) container factory to be used for both types of listener.

I have now deprecated the setters to help users understand the migration path.

I think we can remove auto configuring the legacy error handlers in 3.0 and, yes, suppress the warning in 2.7.

I have removed all the legacy error handler implementations in 3.0 (and deprecated the legacy interfaces).

@snicoll
Copy link
Member Author

snicoll commented Feb 23, 2022

suppress the warning in 2.7

We have to suppress the warning in 2.6 which was my original concern but the fact we already handle CommonErrorHandler answers my question. It would have been ideal to do this at the same time though.

@garyrussell
Copy link
Contributor

It would have been ideal to do this at the same time though.

Yes; it was an omission; sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

3 participants