Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_server_requests_seconds_count missing; webMvcMetricsFilter not instantiated #31263

Closed
ChristianAnke opened this issue Jun 7, 2022 · 1 comment
Closed

http_server_requests_seconds_count missing; webMvcMetricsFilter not instantiated #31263

ChristianAnke opened this issue Jun 7, 2022 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@ChristianAnke
Copy link

Spring Boot 2.7.0

After upgrading my app to spring boot 2.7.0 the http_server_requests_seconds_count prometheus metric is missing.
Found that the bean in charge org.springframework.boot.actuate.autoconfigure.metrics.web.servlet.WebMvcMetricsAutoConfiguration.webMvcMetricsFilter is not instantiated any longer since a @ConditionalOnMissingBean was added.
The debug of the bean initialization:

...
   WebMvcMetricsAutoConfiguration#webMvcMetricsFilter:
      Did not match:
         - @ConditionalOnMissingBean (types: org.springframework.boot.web.servlet.FilterRegistrationBean; SearchStrategy: all) found beans of type 'org.springframework.boot.web.servlet.FilterRegistrationBean' logbackAccessSecurityServletFilter, traceIdInResponseFilterRegistration (OnBeanCondition)
...

shows that there are already FilterRegistrationBeans present which is prohibiting the instantiation of org.springframework.boot.actuate.autoconfigure.metrics.web.servlet.WebMvcMetricsAutoConfiguration.webMvcMetricsFilter?

Example:
test-http-metrics.zip
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 7, 2022
@wilkinsona
Copy link
Member

Thanks for the report and sample. This is a duplicate of #31150.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2022
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 7, 2022
onap-github pushed a commit to onap/policy-parent that referenced this issue Jan 23, 2023
@liamfallon
Upgrade springboot re-enable prometheus http stats
2c137f0 
Springboot 2.5.14 has a bug in its actuator that does not automatically
activate HTTP statiscis. iThis bug is causing our CSITs to fail in the
master branch.

This is fixed in the latest version of Springboot.
See: spring-projects/spring-boot#31263

Issue-ID: POLICY-4143
Change-Id: I04e56e81f06abf0416918df606f1d413b3eb4c1b
Signed-off-by: liamfallon <liam.fallon@est.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wilkinsona @spring-projects-issues @ChristianAnke