Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL RouterFunctions are unordered which prevents other functions from being ordered after them #31314

Closed
bclozel opened this issue Jun 9, 2022 · 0 comments
Closed

GraphQL RouterFunctions are unordered which prevents other functions from being ordered after them #31314

bclozel opened this issue Jun 9, 2022 · 0 comments
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
2.7.1

Comments

@bclozel
Copy link
Member

bclozel commented Jun 9, 2022

As seen in spring-projects/spring-graphql#404, the Spring GraphQL RouterFunction for the GraphQL and GraphiQL endpoints are contributed with no specific ordering, which can make it hard for developers to insert their own relatively.

We should order those at 0 and document this behavior.
@bclozel bclozel added the type: bug A general bug label Jun 9, 2022
@bclozel bclozel added this to the 2.7.x milestone Jun 9, 2022
@rstoyanchev rstoyanchev mentioned this issue Jun 9, 2022
Closed
@wilkinsona wilkinsona changed the title Order GraphQL RouterFunctions at known position GraphQL RouterFunctions are unordered which prevents other functions from being ordered after them Jun 10, 2022
@philwebb philwebb self-assigned this Jun 13, 2022
@philwebb philwebb modified the milestones: 2.7.x, 2.7.1 Jun 14, 2022
This was referenced Jun 24, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.1
Development

No branches or pull requests
2 participants
@bclozel @philwebb