Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that server.max-http-header-size is applied when using HTTP/2 #31330

Closed
wilkinsona opened this issue Jun 10, 2022 · 1 comment
Closed

Test that server.max-http-header-size is applied when using HTTP/2 #31330

wilkinsona opened this issue Jun 10, 2022 · 1 comment
Labels
type: task A general task
Milestone
3.0.0-M4

Comments

@wilkinsona
Copy link
Member

Forward port of issue #31329 to 3.0.x.
@wilkinsona wilkinsona added status: forward-port An issue tracking the forward-port of a change made in an earlier branch type: bug A general bug labels Jun 10, 2022
@wilkinsona wilkinsona added this to the 3.0.0-M4 milestone Jun 10, 2022
@wilkinsona
Copy link
Member Author

wilkinsona commented Jun 10, 2022 •
edited

This isn't needed in 3.0.x due to these changes in Tomcat 10 which mean that the Http2Protocol uses the underlying HTTP 1.1 protocol's max header size. We can keep the new tests to verify that this is the case.

@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: forward-port An issue tracking the forward-port of a change made in an earlier branch labels Jun 10, 2022
@wilkinsona wilkinsona removed this from the 3.0.0-M4 milestone Jun 10, 2022
@wilkinsona wilkinsona added type: task A general task and removed type: bug A general bug status: declined A suggestion or change that we don't feel we should currently apply labels Jun 10, 2022
@wilkinsona wilkinsona added this to the 3.0.0-M4 milestone Jun 10, 2022
@wilkinsona wilkinsona changed the title Tomcat server.max-http-header-size property is ignored when using HTTP/2 Test that server.max-http-header-size is applied when using HTTP/2 Jun 10, 2022
wilkinsona added a commit that referenced this issue Jun 10, 2022
@wilkinsona
Fix compilation error with Tomcat 10
36f01eb 
There's no setter for the max header size in Tomcat 10 as it's now
inherited from the underlying HTTP 1.1 protocol. The test that
was merged forwards from 2.7.x is retained to verify that this is
the case.

See gh-31330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.0.0-M4
Development

No branches or pull requests
1 participant
@wilkinsona