Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Static Content reference documentation to reflect the DefaultServlet no longer being enabled by default #31792

Closed
wilkinsona opened this issue Jul 19, 2022 · 6 comments
Closed

Update Static Content reference documentation to reflect the DefaultServlet no longer being enabled by default #31792

wilkinsona opened this issue Jul 19, 2022 · 6 comments
Assignees
@ionascustefanciprian
Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jul 19, 2022 •
edited

https://docs.spring.io/spring-boot/docs/2.6.9/reference/html/web.html#web.servlet.spring-mvc.static-content

This paragraph is no longer accurate:

In a stand-alone web application, the default servlet from the container is also enabled and acts as a fallback, serving content from the root of the ServletContext if Spring decides not to handle it. Most of the time, this does not happen (unless you modify the default MVC configuration), because Spring can always handle requests through the DispatcherServlet.
@wilkinsona wilkinsona added the type: documentation A documentation update label Jul 19, 2022
@wilkinsona wilkinsona added this to the 2.6.x milestone Jul 19, 2022
@ionascustefanciprian
Copy link
Contributor

Hi @wilkinsona I am a new to open source contribution and I would like to help with this issue. Can you assign it to me?

@wilkinsona
Copy link
Member Author

wilkinsona commented Jul 20, 2022 •
edited

Thanks very much, @ionascustefanciprian. It's all yours. Please let us know if you have any questions.

@wilkinsona wilkinsona changed the title Update Static Content reference documentation to reflect the DefaultService no longer being enabled by default Update Static Content reference documentation to reflect the DefaultServlet no longer being enabled by default Jul 20, 2022
@wilkinsona
Copy link
Member Author

How's it going, @ionascustefanciprian?

@ionascustefanciprian
Copy link
Contributor

Hi. Sorry I have been busy, Next Monday I will focus to open the PR

ionascustefanciprian added a commit to ionascustefanciprian/spring-boot that referenced this issue Aug 8, 2022
@ionascustefanciprian
Update Static Content reference documentation to reflect the DefaultS…
d8910b8 
…ervlet no longer being enabled by default

Closes spring-projectsgh-31792
@ionascustefanciprian ionascustefanciprian mentioned this issue Aug 8, 2022
Closed
@ionascustefanciprian
Copy link
Contributor

Hello @wilkinsona I have opened a new PR #32004

@wilkinsona
Copy link
Member Author

Thanks very much, @ionascustefanciprian. I'll close this issue in favor of your PR.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2022
@wilkinsona wilkinsona removed this from the 2.6.x milestone Aug 8, 2022
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ionascustefanciprian ionascustefanciprian

Labels
status: superseded An issue that has been superseded by another type: documentation A documentation update
Projects
None yet
Milestone
No milestone
2 participants
@wilkinsona @ionascustefanciprian