Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some properties in the Common Application Properties appendix have no description #31916

Closed
wilkinsona opened this issue Jul 29, 2022 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jul 29, 2022

There are several properties in the appendix that have no description. This generally seems to be because they use @NestedConfigurationProperty to refer to a type in another module. With this arrangement, the source of the nested configuration property class is not available so the description cannot be harvested from the javadoc. This is a known problem that we're not sure how to solve. Until we're able to come up with a solution, we can continue to rely on additional metadata instead. To help to avoid the problem happening again, perhaps we can fail the build if a property has no description.

@wilkinsona wilkinsona added the type: documentation A documentation update label Jul 29, 2022
@wilkinsona wilkinsona added this to the 2.6.x milestone Jul 29, 2022
@wilkinsona wilkinsona self-assigned this Jul 29, 2022
@weixsun
Copy link
Contributor

weixsun commented Jul 29, 2022

I also noticed this issue and I always feel like a little thing is off, but I don't know where it is

@wilkinsona
Copy link
Member Author

Working on this has shown that the problem tackled by #28075 occurs more frequently than I'd realised during local builds. With something in place to check that all properties have descriptions, the problem sometimes causes local build failures. The build passes if full compilation is forced, for example by deleting build/classes, and sometimes also requires --no-build-cache if the local cache has been polluted with incomplete metadata.

@wilkinsona
Copy link
Member Author

#28075 is proving rather difficult to fix. For the time being at least, I have worked around it by disabling incremental compilation in our build for modules using the annotation processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants