Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @ConditionalOnClass javadoc regarding use on @Bean methods #32166

Closed
philwebb opened this issue Aug 25, 2022 · 3 comments
Closed

Improve @ConditionalOnClass javadoc regarding use on @Bean methods #32166

philwebb opened this issue Aug 25, 2022 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@philwebb
Copy link
Member

As suggested in #15578 (comment), we have information in the reference docs that would also be beneficial in the javadoc

@bondolo
Copy link

bondolo commented Aug 25, 2022

Thank you! This is a great improvement. It will still probably be mysterious for users when they encounter the failure after innocently putting @ConditionalOnClass on a @Bean but the javadoc now adequately explains the problem and a remedy!

@vpavic
Copy link
Contributor

vpavic commented Aug 25, 2022

Suggestion for 2.7+: wouldn't it be a good idea to also refer to @AutoConfiguration here, since that's what one would use on something like MyAutoConfiguration these days?

philwebb added a commit that referenced this issue Aug 25, 2022
@philwebb
Copy link
Member Author

Good spot @vpavic, I've now fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

3 participants