Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NINETEEN to JavaVersion enum #32226

Closed
pruidong opened this issue Sep 4, 2022 · 1 comment
Closed

Add NINETEEN to JavaVersion enum #32226

pruidong opened this issue Sep 4, 2022 · 1 comment
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
2.6.12

Comments

@pruidong
Copy link
Contributor

pruidong commented Sep 4, 2022

I prepared a PR for this. But when running the tests, I found that junit needs to be upgraded to 5.9.0, in order for the tests to work (Spring Boot currently depends on junit 5.8.2).

Please what can I do for this? Thanks.
@pruidong
Copy link
Contributor Author

pruidong commented Sep 4, 2022

junit JRE.java:

https://github.com/junit-team/junit5/blob/r5.9.0/junit-jupiter-api/src/main/java/org/junit/jupiter/api/condition/JRE.java#L131

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 4, 2022
@wilkinsona wilkinsona changed the title Add Java 19 to JavaVersion.java Add NINETEEN to JavaVersion enum Sep 8, 2022
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 8, 2022
@wilkinsona wilkinsona added this to the 2.6.x milestone Sep 8, 2022
@wilkinsona wilkinsona self-assigned this Sep 8, 2022
@wilkinsona wilkinsona mentioned this issue Sep 8, 2022
Closed
@wilkinsona wilkinsona modified the milestones: 2.6.x, 2.6.12 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.6.12
Development

No branches or pull requests
3 participants
@wilkinsona @pruidong @spring-projects-issues