Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Tomcat 10.1.4 #33167

Closed
wilkinsona opened this issue Nov 14, 2022 · 4 comments
Closed

Upgrade to Tomcat 10.1.4 #33167

wilkinsona opened this issue Nov 14, 2022 · 4 comments
Assignees
@mhalbritter
Labels
type: dependency-upgrade A dependency upgrade
Milestone
3.0.1

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label Nov 14, 2022
@wilkinsona wilkinsona added this to the 3.0.0 milestone Nov 14, 2022
wilkinsona added a commit that referenced this issue Nov 14, 2022
@wilkinsona
Revert "Upgrade to Tomcat 10.1.2"
6d8a1c9 
This reverts commit 4ccdfc6.

See gh-33167
See gh-33071
@wilkinsona
Copy link
Member Author

I have reverted this change for now at least as it breaks the build with failures like this:

Caused by: org.springframework.context.ApplicationContextException: Unable to start web server
	at app//org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:164)
	at app//org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:578)
	at app//org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:146)
	at app//org.springframework.boot.SpringApplication.refresh(SpringApplication.java:730)
	at app//org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:432)
	at app//org.springframework.boot.SpringApplication.run(SpringApplication.java:308)
	at app//org.springframework.boot.test.context.SpringBootContextLoader.lambda$loadContext$3(SpringBootContextLoader.java:134)
	at app//org.springframework.util.function.ThrowingSupplier.get(ThrowingSupplier.java:59)
	at app//org.springframework.util.function.ThrowingSupplier.get(ThrowingSupplier.java:47)
	at app//org.springframework.boot.SpringApplication.withHook(SpringApplication.java:1386)
	at app//org.springframework.boot.test.context.SpringBootContextLoader$ContextLoaderHook.run(SpringBootContextLoader.java:526)
	at app//org.springframework.boot.test.context.SpringBootContextLoader.loadContext(SpringBootContextLoader.java:134)
	at app//org.springframework.boot.test.context.SpringBootContextLoader.loadContext(SpringBootContextLoader.java:105)
	at app//org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContextInternal(DefaultCacheAwareContextLoaderDelegate.java:183)
	at app//org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:117)
	... 88 more
Caused by: java.lang.NoClassDefFoundError: org/apache/tomcat/jakartaee/EESpecProfile
	at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.prepareContext(TomcatServletWebServerFactory.java:244)
	at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getWebServer(TomcatServletWebServerFactory.java:209)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:183)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:161)
	... 102 more
Caused by: java.lang.ClassNotFoundException: org.apache.tomcat.jakartaee.EESpecProfile
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	... 106 more

@wilkinsona wilkinsona reopened this Nov 14, 2022
@markt-asf
Copy link

It appears the refactoring that made EESpecProfile an interface and EESpecProfiles the enum triggered this.

Refactoring the addition of the migration tool transformer to an inner class fixes this for my local test case.There should be a snapshot available to test with in the ASF snapshot repo in an hour or two.

@wilkinsona
Copy link
Member Author

Thanks, Mark. Boot builds cleanly with 10.1.3-SNAPSHOT.

@wilkinsona wilkinsona changed the title Upgrade to Tomcat 10.1.2 Upgrade to Tomcat 10.1.3 Nov 15, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.0, 3.0.x Nov 15, 2022
@sdeleuze
Copy link
Contributor

Tomcat 10.1.3 has been cancelled but 10.1.4 has been released instead.

@mhalbritter mhalbritter changed the title Upgrade to Tomcat 10.1.3 Upgrade to Tomcat 10.1.4 Dec 12, 2022
@mhalbritter mhalbritter self-assigned this Dec 12, 2022
@mhalbritter mhalbritter modified the milestones: 3.0.x, 3.0.1 Dec 12, 2022
garretwilson added a commit to globalmentor/guise-mummy that referenced this issue Aug 5, 2023
@garretwilson
Updated embedded Tomcat version.
3306837 
v10.1.2 could not find class `org.apache.tomcat.jakartaee.EESpecProfile`.
See related: spring-projects/spring-boot#33167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
4 participants
@sdeleuze @wilkinsona @markt-asf @mhalbritter