Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SslStoreBundle implementations aren't immutable #37222

Closed
mhalbritter opened this issue Sep 7, 2023 · 0 comments
Closed

SslStoreBundle implementations aren't immutable #37222

mhalbritter opened this issue Sep 7, 2023 · 0 comments
Labels
type: bug A general bug
Milestone
3.1.4

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Sep 7, 2023 •
edited

Our existing SslStoreBundle implementations, JksSslStoreBundle and PemSslStoreBundle, are not immutable. They create the key- and truststore on every get* method call, which can reload the (changed) key material from disk.

For correctness and performance reasons we should make them immutable.
@mhalbritter mhalbritter added the type: bug A general bug label Sep 7, 2023
@mhalbritter mhalbritter added this to the 3.1.x milestone Sep 7, 2023
@mhalbritter mhalbritter mentioned this issue Sep 11, 2023
Closed
@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.4 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.4
Development

No branches or pull requests
1 participant
@mhalbritter