Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting 'spring.task.execution.shutdown.await-termination-period' does not result in a call to SimpleAsyncTaskExecutor#taskTerminationTimeout #38528

Closed
NicklasWallgren opened this issue Nov 24, 2023 · 0 comments
Closed

Setting 'spring.task.execution.shutdown.await-termination-period' does not result in a call to SimpleAsyncTaskExecutor#taskTerminationTimeout #38528

NicklasWallgren opened this issue Nov 24, 2023 · 0 comments
Assignees
@mhalbritter
Labels
type: bug A general bug
Milestone
3.2.1

Comments

@NicklasWallgren
Copy link

NicklasWallgren commented Nov 24, 2023 •
edited

SimpleAsyncTaskExecutor got support for graceful termination in Spring Framework 6.1.

I think it would be helpful to be able to configure the taskTerminationTimeout value, either via the existing spring.task.execution.shutdown.await-termination-period or a new property.

#35710 (comment)
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 24, 2023
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 24, 2023
@mhalbritter mhalbritter added this to the 3.x milestone Nov 24, 2023
@mhalbritter mhalbritter changed the title Configure SimpleAsyncTaskExecutor#taskTerminationTimeout via property Add property for SimpleAsyncTaskExecutor#taskTerminationTimeout Nov 24, 2023
This was referenced Nov 24, 2023
Closed
Closed
@wilkinsona wilkinsona added the for: team-meeting An issue we'd like to discuss as a team to make progress label Nov 24, 2023
@philwebb philwebb modified the milestones: 3.x, 3.2.x Nov 27, 2023
@philwebb philwebb added type: bug A general bug and removed for: team-meeting An issue we'd like to discuss as a team to make progress type: enhancement A general enhancement labels Nov 27, 2023
@philwebb philwebb changed the title Add property for SimpleAsyncTaskExecutor#taskTerminationTimeout Setting 'spring.task.execution.shutdown.await-termination-period' does not result in a call to SimpleAsyncTaskExecutor#taskTerminationTimeout Nov 27, 2023
@mhalbritter mhalbritter self-assigned this Nov 28, 2023
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.1 Nov 30, 2023
mhalbritter added a commit that referenced this issue Nov 30, 2023
@mhalbritter
Only apply awaitTerminationPeriod if awaitTermination is set
fdbd65a 
See gh-38528
This was referenced Dec 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: bug A general bug
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
5 participants
@philwebb @wilkinsona @NicklasWallgren @spring-projects-issues @mhalbritter