You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In 3.2.0, we deprecated management.metrics.tags (MetricsProperties#getTags). The replacement for this is management.observations.key-values, but this property is only applied to metrics created through Observations. If creating metrics in a different way, management.observations.key-values is not applied to these metrics.
I currently see these ways forward:
Un-deprecate management.metrics.tags - then we whould have two places to set common tags for metrics, depending how they get created, which is not great.
Apply management.observations.key-values to metrics created without a Observation, too - then we would only have one way to set common tags for metrics, which is great. But the observations part implies that it should only apply to Observations. Or is a metric an Observation, too?
Create a new property, e.g. management.observability.common-tags which applies to all observability things (Observation, metrics, traces). Then we have to deprecate the new management.observations.key-values and redirect users to management.observability.common-tags.
The text was updated successfully, but these errors were encountered:
We discussed this today and we're leaning towards the 3rd option although we have some reservations about the subtle difference between observation and observability. We'd like to discuss it some more before making a final decision.
this property is only applied to metrics created through Observations. If creating metrics in a different way [...]
"in a different way" includes all the "default" JVM metrics which we can probably expect that nearly-everyone cares about (ie it's not really a niche thing)
(also no opinion on what solution here is best, trusting you will do something nice 👍)
In 3.2.0, we deprecated
management.metrics.tags
(MetricsProperties#getTags
). The replacement for this ismanagement.observations.key-values
, but this property is only applied to metrics created throughObservation
s. If creating metrics in a different way,management.observations.key-values
is not applied to these metrics.I currently see these ways forward:
management.metrics.tags
- then we whould have two places to set common tags for metrics, depending how they get created, which is not great.management.observations.key-values
to metrics created without aObservation
, too - then we would only have one way to set common tags for metrics, which is great. But theobservations
part implies that it should only apply toObservation
s. Or is a metric anObservation
, too?management.observability.common-tags
which applies to all observability things (Observation
, metrics, traces). Then we have to deprecate the newmanagement.observations.key-values
and redirect users tomanagement.observability.common-tags
.The text was updated successfully, but these errors were encountered: