Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

management.metrics.tags has been deprecated without a replacement working for all metrics #38583

Closed
mhalbritter opened this issue Nov 28, 2023 · 4 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Nov 28, 2023

In 3.2.0, we deprecated management.metrics.tags (MetricsProperties#getTags). The replacement for this is management.observations.key-values, but this property is only applied to metrics created through Observations. If creating metrics in a different way, management.observations.key-values is not applied to these metrics.

I currently see these ways forward:

  • Un-deprecate management.metrics.tags - then we whould have two places to set common tags for metrics, depending how they get created, which is not great.
  • Apply management.observations.key-values to metrics created without a Observation, too - then we would only have one way to set common tags for metrics, which is great. But the observations part implies that it should only apply to Observations. Or is a metric an Observation, too?
  • Create a new property, e.g. management.observability.common-tags which applies to all observability things (Observation, metrics, traces). Then we have to deprecate the new management.observations.key-values and redirect users to management.observability.common-tags.
@mhalbritter mhalbritter added the type: bug A general bug label Nov 28, 2023
@mhalbritter mhalbritter added this to the 3.2.x milestone Nov 28, 2023
@mhalbritter mhalbritter added the for: team-meeting An issue we'd like to discuss as a team to make progress label Nov 28, 2023
@wilkinsona
Copy link
Member

We discussed this today and we're leaning towards the 3rd option although we have some reservations about the subtle difference between observation and observability. We'd like to discuss it some more before making a final decision.

@Tristan971
Copy link

Tristan971 commented Dec 10, 2023

Maybe worth a note in the release notes paragraph associated? (if editing those is possible)

Because in this sentence

this property is only applied to metrics created through Observations. If creating metrics in a different way [...]

"in a different way" includes all the "default" JVM metrics which we can probably expect that nearly-everyone cares about (ie it's not really a niche thing)

(also no opinion on what solution here is best, trusting you will do something nice 👍)

@mhalbritter
Copy link
Contributor Author

I will fix that section of the release notes when we have made our decision.

@mhalbritter mhalbritter self-assigned this Dec 12, 2023
@mhalbritter mhalbritter removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Dec 13, 2023
@mhalbritter
Copy link
Contributor Author

We decided to undeprecate management.metrics.tags for now, and we'll rethink about the whole tags (and key-values) situation in a next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

3 participants