Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failures due to code not being compiled with '-parameters' are hard to identify #38603

Closed
philwebb opened this issue Nov 29, 2023 · 1 comment
Closed

Failures due to code not being compiled with '-parameters' are hard to identify #38603

philwebb opened this issue Nov 29, 2023 · 1 comment
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
3.2.1

Comments

@philwebb
Copy link
Member

The -parameters requirement is catching a lot of folks out and our binder doesn't currently do a good job of throwing a useful exception. We should improve this and possibly consider a failure analyzer.
@philwebb philwebb added the type: enhancement A general enhancement label Nov 29, 2023
@philwebb philwebb added this to the 3.2.x milestone Nov 29, 2023
@philwebb philwebb mentioned this issue Nov 30, 2023
Closed
@wilkinsona wilkinsona changed the title Improve binding exception caused when project has not been compiled with '-parameters' Binding failures due to code not being compiled with '-parameters' are hard to identify Dec 4, 2023
@wilkinsona wilkinsona added type: bug A general bug and removed type: enhancement A general enhancement labels Dec 4, 2023
@philwebb philwebb changed the title Binding failures due to code not being compiled with '-parameters' are hard to identify Failures due to code not being compiled with '-parameters' are hard to identify Dec 5, 2023
@philwebb
Copy link
Member Author

philwebb commented Dec 5, 2023

See spring-projects/spring-framework#31675 for related Spring Framework issue

@philwebb philwebb self-assigned this Dec 5, 2023
philwebb added a commit that referenced this issue Dec 5, 2023
@philwebb
Add suppressed missing parameters exception from ValueObjectBinder
f609022 
Update `DataObjectBinder` interface and `ValueObjectBinder`
implementation so that suppressed exceptions are added whenever
parameter names cannot be discovered.

See gh-38603
@philwebb philwebb modified the milestones: 3.2.x, 3.2.1 Dec 5, 2023
@philwebb philwebb mentioned this issue Dec 17, 2023
Closed
This was referenced Dec 22, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona