Avoid duplicate classes in MergedContextConfiguration #24532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
for: stackoverflow
wilkinsona
reviewed
Dec 16, 2020
...t/src/main/java/org/springframework/boot/test/context/SpringBootTestContextBootstrapper.java
Outdated
Show resolved
Hide resolved
philwebb
pushed a commit
that referenced
this pull request
Dec 16, 2020
Remove duplicate config attribute classes by using a `Set` rather than a `List` in the `SpringBootTestContextBootstrapper`. See gh-24532
|
Thanks @dreis2211. I merged this into 2.3.x, 2.4.x and master. |
|
@philwebb Thanks. On that note: is there a 2.5.x / master pipeline on Concourse yet? |
|
|
@snicoll Thanks, but the page is blank for me. Also, the build status badge inside the README can't be displayed at the moment. Seems like a permission problem. |
|
The pipeline should be visible now. |
|
Indeed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just noticed the following log while debugging some test context cache optimizations in one of my projects:
It's trimmed down, but as you can see
classescontains the same class twice. This seems to be happen when I explicitly declare theclasseson@SpringBootTestas follows:While not critical at all, I guess we can make an effort to avoid the duplicates. That should fix the logs and maybe saves a few cycles on the road (although that impact should be veeery small as the duplicates are filtered in
SpringApplicationthe latest).Let me know what you think.
Cheers,
Christoph