Document the need to use the launcher to be able to use application.* properties in a custom banner #24982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation.* properties in unpacked jars.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: documentation
wilkinsona
changed the title
philwebb
pushed a commit
that referenced
this pull request
Jan 29, 2021
Add a note to the "Customizing the Banner" explaining that you need to be using the `JarLauncher` to use the `application.*` properties. See gh-24982
philwebb
added a commit
that referenced
this pull request
Jan 29, 2021
|
Thanks @robert-smith-911. I've merged this to 2.3.x and forward with a slight tweak to the wording since you you don't need the |
|
Thanks @philwebb ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a documentation update to describe the need to use JarLauncher to use application.* properties in custom banner. This is in response to issue 22519