Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.springframework.boot.actuate.autoconfigure.metrics.graphql has no package info #31140

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

  • Add missing package-info.java
  • Update checkstyle-suppresion.xml

See gh-31123

* Add missing `package-info.java`
* Update `checkstyle-suppresion.xml`

See spring-projectsgh-31123
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 21, 2022
@wilkinsona
Copy link
Member

TIL about Checkstyle's JavadocPackageCheck. Thanks, @eddumelendez. I wonder if we should add this to Spring Java Format, alongside the existing Javadoc-related checks.

@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label May 23, 2022
@wilkinsona
Copy link
Member

I've opened spring-io/spring-javaformat#328 to made JavadocPackageCheck part of the default Spring checks.

@wilkinsona wilkinsona added for: merge-with-amendments Needs some changes when we merge and removed for: team-attention An issue we'd like other members of the team to review labels May 23, 2022
@wilkinsona wilkinsona changed the title Add JavadocPackageCheck to checkstyle config org.springframework.boot.actuate.autoconfigure.metrics.graphql has no package info May 25, 2022
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged for: merge-with-amendments Needs some changes when we merge labels May 25, 2022
@wilkinsona wilkinsona added this to the 2.7.x milestone May 25, 2022
@wilkinsona wilkinsona self-assigned this May 25, 2022
wilkinsona pushed a commit that referenced this pull request May 25, 2022
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.1 May 25, 2022
@wilkinsona
Copy link
Member

Thanks very much, @eddumelendez. I've just kept the package-info for GraphQL metrics. The other changes will be taken care of as part of a Java Format upgrade across all maintained branches (#31166).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants