Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Bean methods in KafkaAutoConfiguration provide less type information than they could #32770

Closed
wants to merge 1 commit into from

Conversation

YuanHao97
Copy link

@YuanHao97 YuanHao97 commented Oct 18, 2022

As pointed out by @maciejwalkowiak in #32763, there are a number of @Bean methods in KafkaAutoConfiguration where the return type isn't as specific as it could be. For example, kafkaConsumerFactory always returns a DefaultKafkaConsumerFactory but its return type is only ConsumerFactory.

See #32766

@pivotal-cla
Copy link

@YuanHao97 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@YuanHao97 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 18, 2022
@YuanHao97
Copy link
Author

I don't have access to CI build detail, not sure why CI build failed. The unit test KafkaAutoConfigurationTests works fine locally.

@philwebb philwebb changed the title make KafkaAutoConfiguration return more specific implemented bean type @Bean methods in KafkaAutoConfiguration provide less type information than they could Oct 18, 2022
@philwebb philwebb added type: bug A general bug for: merge-with-amendments Needs some changes when we merge and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 18, 2022
@philwebb philwebb added this to the 2.6.x milestone Oct 18, 2022
@philwebb philwebb modified the milestones: 2.6.x, 2.6.13 Oct 18, 2022
philwebb pushed a commit that referenced this pull request Oct 18, 2022
Update `KafkaAutoConfiguration` so that more specific bean types are
returned.

See gh-32770
@philwebb philwebb closed this in e35de71 Oct 18, 2022
@YuanHao97 YuanHao97 deleted the 2.6.x branch October 19, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: merge-with-amendments Needs some changes when we merge type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants